all: replace strings.Replace(_, -1) with strings.ReplaceAll#3697
Open
Deln0r wants to merge 1 commit into
Open
Conversation
staticcheck QF1004 prefers strings.ReplaceAll over strings.Replace with a -1 count: the intent of replace-everywhere is clearer in the name and matches the form added to the standard library in Go 1.12. Three call sites: - internal/pushrules/util.go: glob-to-regex translation - syncapi/storage/postgres/filtering.go: glob-to-LIKE translation No behavior change. Signed-off-by: Ian Chechin <ian00chechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
staticcheck
QF1004prefersstrings.ReplaceAlloverstrings.Replacewith a-1count: the intent of replace-everywhere is clearer in the name and matches the form added to the standard library in Go 1.12.Three call sites across two files:
internal/pushrules/util.go— glob-to-regex translation (*→.*,?→.)syncapi/storage/postgres/filtering.go— glob-to-LIKE translation (*→%)No behavior change.
Test plan
go build ./...clean